Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Multiple generic interfaces #239

Merged
merged 1 commit into from
Oct 19, 2023
Merged

tests: Multiple generic interfaces #239

merged 1 commit into from
Oct 19, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Oct 11, 2023 •
edited
Loading

closes #226

@jawoznia jawoznia requested a review from hashedone October 11, 2023 10:55
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #239 (246cba3) into feat/generics_support (f046d9e) will increase coverage by 0.41%.
Report is 1 commits behind head on feat/generics_support.
The diff coverage is 89.39%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #239      +/-   ##
=========================================================
+ Coverage                  88.36%   88.77%   +0.41%     
=========================================================
  Files                         25       25              
  Lines                       1444     1488      +44     
=========================================================
+ Hits                        1276     1321      +45     
+ Misses                       168      167       -1
Files Coverage Δ
sylvia-derive/src/interfaces.rs 90.65% <100.00%> (+2.14%) ⬆️
sylvia-derive/src/message.rs 87.35% <100.00%> (ø)
sylvia/tests/generics.rs 88.88% <81.81%> (+88.88%) ⬆️
sylvia-derive/src/parser.rs 83.09% <64.28%> (-1.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the support_multiple_generic_interfaces branch from 06ddd7d to b3b3c42 Compare October 11, 2023 12:50
@jawoznia jawoznia force-pushed the support_generic_messages_on_contract branch from 04e0edd to fd40f3d Compare October 18, 2023 11:07
@jawoznia jawoznia force-pushed the support_multiple_generic_interfaces branch from b3b3c42 to 0775fa5 Compare October 18, 2023 11:21
@jawoznia jawoznia changed the title feat: Multiple generic interfaces tests: Multiple generic interfaces Oct 18, 2023
@jawoznia jawoznia mentioned this pull request Oct 19, 2023
Merged
Base automatically changed from support_generic_messages_on_contract to feat/generics_support October 19, 2023 10:38
@jawoznia jawoznia force-pushed the support_multiple_generic_interfaces branch from 0775fa5 to 4e33f09 Compare October 19, 2023 10:43
hashedone
hashedone approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia force-pushed the support_multiple_generic_interfaces branch from 4e33f09 to 246cba3 Compare October 19, 2023 13:24
@jawoznia jawoznia merged commit b2805a9 into feat/generics_support Oct 19, 2023
7 checks passed
@jawoznia jawoznia deleted the support_multiple_generic_interfaces branch October 19, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone